Repository navigation
Feat: numpy array parameters, step 1 (#220) - #263
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #220 (step 1 of 2; step 2 is warnings and division).
Element-only numpy float64/int64 parameters take the buffer path (C-contiguous, 1-D, exact ndarray, else the object path); results are boxed as the interpreter's numpy scalar type via a run-time taint flag; pure functions deopt on a non-finite + - * result or an unproved int overflow so the interpreter emits numpy's warning; division, impure arithmetic on elements and stores of element values stay interpreted until step 2. Functions using the array as a whole object keep compiling with an opaque parameter (no regression, tests whole_sum/whole_attr/whole_pass). A numpy-derived value never becomes INT. Bool arrays: #261.
Red: new test_buffer_numpy.py 19 failed, 10 passed before implementation. Local 3.15t full suite: 1298 passed, 3 skipped. Benchmark compiled set identical to develop (test_the_benchmarks_compile_the_same_functions_as_before; benchmarks use no numpy).